- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 33.6k
test: remove test-domain-error-types flaky designation #51717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            nodejs-github-bot
  merged 1 commit into
  nodejs:main
from
lpinca:remove/flaky-test-domain-error-types
  
      
      
   
  Feb 16, 2024 
      
    
                
     Merged
            
            test: remove test-domain-error-types flaky designation #51717
                    nodejs-github-bot
  merged 1 commit into
  nodejs:main
from
lpinca:remove/flaky-test-domain-error-types
  
      
      
   
  Feb 16, 2024 
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    There is no recent trace of failure for this test. Fixes: nodejs#38063
              
                    targos
  
              
              approved these changes
              
                  
                    Feb 10, 2024 
                  
              
              
            
            
              
                    benjamingr
  
              
              approved these changes
              
                  
                    Feb 10, 2024 
                  
              
              
            
            
              
                    mertcanaltin
  
              
              approved these changes
              
                  
                    Feb 12, 2024 
                  
              
              
            
            
| Landed in 78273ed | 
    
  targos 
      pushed a commit
      that referenced
      this pull request
    
      Feb 19, 2024 
    
    
      
  
    
      
    
  
There is no recent trace of failure for this test. Fixes: #38063 PR-URL: #51717 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
      
     Merged
  
    
  rdw-msft 
      pushed a commit
        to rdw-msft/node
      that referenced
      this pull request
    
      Mar 20, 2024 
    
    
      
  
    
      
    
  
There is no recent trace of failure for this test. Fixes: nodejs#38063 PR-URL: nodejs#51717 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
    
  richardlau 
      pushed a commit
      that referenced
      this pull request
    
      Mar 25, 2024 
    
    
      
  
    
      
    
  
There is no recent trace of failure for this test. Fixes: #38063 PR-URL: #51717 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
    
  richardlau 
      pushed a commit
      that referenced
      this pull request
    
      Mar 25, 2024 
    
    
      
  
    
      
    
  
There is no recent trace of failure for this test. Fixes: #38063 PR-URL: #51717 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
      
     Merged
  
    
  codebytere 
      added a commit
        to electron/electron
      that referenced
      this pull request
    
      Apr 14, 2024 
    
    
  
    
  codebytere 
      added a commit
        to electron/electron
      that referenced
      this pull request
    
      Apr 16, 2024 
    
    
  
    
  jkleinsc 
      pushed a commit
        to electron/electron
      that referenced
      this pull request
    
      Apr 17, 2024 
    
    
      
  
    
      
    
  
* chore: bump node in DEPS to v20.12.0 * chore: update build_add_gn_build_files.patch * chore: update patches * chore: bump node in DEPS to v20.12.1 * chore: update patches * build: encode non-ASCII Latin1 characters as one byte in JS2C nodejs/node#51605 * crypto: use EVP_MD_fetch and cache EVP_MD for hashes nodejs/node#51034 * chore: update filenames.json * chore: bump node in DEPS to v20.12.2 * chore: update patches * src: support configurable snapshot nodejs/node#50453 * test: remove test-domain-error-types flaky designation nodejs/node#51717 * src: avoid draining platform tasks at FreeEnvironment nodejs/node#51290 * chore: fix accidentally deleted v8 dep * lib: define FormData and fetch etc. in the built-in snapshot nodejs/node#51598 * chore: rebase on main * chore: remove stray log --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Cheng <[email protected]> Co-authored-by: Shelley Vohr <[email protected]> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
    
  codebytere 
      added a commit
        to electron/electron
      that referenced
      this pull request
    
      May 31, 2024 
    
    
  
    
  codebytere 
      added a commit
        to electron/electron
      that referenced
      this pull request
    
      Jun 1, 2024 
    
    
      
  
    
      
    
  
* chore: bump node in DEPS to v20.13.1 * chore: bump node in DEPS to v20.14.0 * chore: update build_add_gn_build_files.patch * chore: update patches * chore: update patches * build: encode non-ASCII Latin1 characters as one byte in JS2C nodejs/node#51605 * crypto: use EVP_MD_fetch and cache EVP_MD for hashes nodejs/node#51034 * chore: update filenames.json * chore: update patches * src: support configurable snapshot nodejs/node#50453 * test: remove test-domain-error-types flaky designation nodejs/node#51717 * src: avoid draining platform tasks at FreeEnvironment nodejs/node#51290 * chore: fix accidentally deleted v8 dep * lib: define FormData and fetch etc. in the built-in snapshot nodejs/node#51598 * chore: remove stray log * crypto: enable NODE_EXTRA_CA_CERTS with BoringSSL nodejs/node#52217 * test: skip test for dynamically linked OpenSSL nodejs/node#52542 * lib, url: add a `windows` option to path parsing nodejs/node#52509 * src: use dedicated routine to compile function for builtin CJS loader nodejs/node#52016 * test: mark test as flaky nodejs/node#52671 * build,tools: add test-ubsan ci nodejs/node#46297 * src: preload function for Environment nodejs/node#51539 * deps: update c-ares to 1.28.1 nodejs/node#52285 * chore: fixup * events: extract addAbortListener for safe internal use nodejs/node#52081 * module: print location of unsettled top-level await in entry points nodejs/node#51999 * fs: add stacktrace to fs/promises nodejs/node#49849 * chore: fixup indices --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Cheng <[email protected]> Co-authored-by: Shelley Vohr <[email protected]> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There is no recent trace of failure for this test.
Fixes: #38063